Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Mount the ovs directory for tcp-network-controller #72

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Aug 8, 2018

Use the DumpOVSPorts in the network-controller, we will get the following error message.
Failed to dump ports: exit status 1: ovs-ofctl: peaceful_cori is not a bridge or a socket
The reason is that we don't have the peaceful_cori.mgnt unix socker in the network-controller container.

So, we should mount whole ovs directory into the container.

linkernetworks/vortex#232

@hwchiu hwchiu requested a review from sufuf3 August 8, 2018 08:24
@codecov
Copy link

codecov bot commented Aug 8, 2018

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   87.68%   87.68%           
=======================================
  Files           7        7           
  Lines         203      203           
=======================================
  Hits          178      178           
  Misses         16       16           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f8b823...22e29e7. Read the comment docs.

@hwchiu hwchiu requested a review from John-Lin August 8, 2018 09:04
Copy link
Contributor

@sufuf3 sufuf3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@John-Lin John-Lin merged commit 8953aea into master Aug 8, 2018
@John-Lin John-Lin deleted the hwchiu/VX-257 branch August 13, 2018 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants