Add add route func in container #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 87.17% 87.74% +0.56%
==========================================
Files 7 7
Lines 195 204 +9
==========================================
+ Hits 170 179 +9
Misses 16 16
Partials 9 9
Continue to review full report at Codecov.
|
John-Lin
suggested changes
Jul 18, 2018
nl/link.go
Outdated
| func AddRoute(ipn *net.IPNet, dev string) error { | ||
| link, err := netlink.LinkByName(dev) | ||
| if err != nil { | ||
| fmt.Print(err) |
John-Lin
reviewed
Jul 18, 2018
messages/messages.proto
Outdated
|
|
||
| message ConfigureRouteRequest { | ||
| string path = 1; | ||
| string dstIPNet = 2; |
|
rebase and add some test cases |
|
Got it. |
sufuf3
force-pushed
the
sufuf3/add-route
branch
3 times, most recently
from
3b541e3
to
59d0ab4
Compare
|
I rebase to the latest master and used https://github.com/cweill/gotests to generate the go test. |
sufuf3
force-pushed
the
sufuf3/add-route
branch
4 times, most recently
from
73a7a0a
to
f2bc4a7
Compare
|
現在有考慮要把 gw加回來 下週我們討論一下再改 |
|
好唷 |
sufuf3
changed the title
|
@John-Lin I finished this PR. |
sufuf3
force-pushed
the
sufuf3/add-route
branch
3 times, most recently
from
f649fa1
to
c6815c7
Compare
sufuf3
force-pushed
the
sufuf3/add-route
branch
3 times, most recently
from
35a944b
to
2f262ac
Compare
hwchiu
approved these changes
Jul 23, 2018
John-Lin
approved these changes
Jul 23, 2018
chenyunchen
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.