Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all vagrant stuff #55

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Conversation

John-Lin
Copy link
Contributor

@John-Lin John-Lin commented Jul 5, 2018

Use vortex project Vagrantfile instead

@codecov
Copy link

codecov bot commented Jul 5, 2018

Codecov Report

Merging #55 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   86.91%   86.91%           
=======================================
  Files           7        7           
  Lines         191      191           
=======================================
  Hits          166      166           
  Misses         16       16           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39388fa...5653a72. Read the comment docs.

Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@John-Lin John-Lin merged commit 6732f11 into master Jul 6, 2018
@hwchiu hwchiu deleted the johnlin/remove-vagrant-stuff branch July 17, 2018 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants