Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add using the vagrant description #44

Merged
merged 3 commits into from
Jun 19, 2018
Merged

Add using the vagrant description #44

merged 3 commits into from
Jun 19, 2018

Conversation

sufuf3
Copy link
Contributor

@sufuf3 sufuf3 commented Jun 15, 2018

I will add configure access to vagrant clusters description later.

@codecov
Copy link

codecov bot commented Jun 15, 2018 •
edited
Loading

Codecov Report

Merging #44 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files           7        7           
  Lines         182      182           
=======================================
  Hits          158      158           
  Misses         15       15           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 677a238...707681f. Read the comment docs.

hwchiu
hwchiu reviewed Jun 15, 2018
View reviewed changes
README.md Outdated
@@ -17,6 +17,28 @@ make client
make test
```

### Develop with Vagrant
1. Download repository
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this since we are already in this project lol

README.md Outdated
```sh
$ vagrant up
```
3. Install vagrant-scp plugin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can write a makefile for those command and install the vagrant-scp inside the makefile

@sufuf3
Copy link
Contributor Author

sufuf3 commented Jun 16, 2018 •
edited
Loading

@hwchiu Thank you for the suggestions.
I updated the README, also follow linkernetworks/vortex#5 and updated Vagrantfile & some dependents.
The second commit I amended the author name as you because I think this is your credit that you figure out this solution.
If there is something that I need to revise, please let me know.

Thank you very much.

hwchiu
hwchiu approved these changes Jun 16, 2018
View reviewed changes
Copy link
Contributor

@hwchiu hwchiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwchiu
Copy link
Contributor

hwchiu commented Jun 16, 2018

@sufuf3 我其實沒意見lol 大家一起幫忙的

@sufuf3 sufuf3 force-pushed the sufuf3/add-dev-readme branch 4 times, most recently from dc57308 to 8255914 Compare June 19, 2018 02:28
Hung-Wei Chiu and others added 2 commits June 19, 2018 10:37
@sufuf3
Support Docker-client & kubectl on host
2a39ed2 
People can use this on their host & manipulate Ubuntu VM.
- Update Vagrantfile add k8s api-server address & docker config file.
- Update README.md for developers.
- Add vagrant-docker.conf for docker config file of Vagrantfile.
- Update Makefile: Add Vagrant setup part.
@sufuf3
Update gitignore
707681f
@hwchiu hwchiu merged commit 390b51b into master Jun 19, 2018
@John-Lin John-Lin deleted the sufuf3/add-dev-readme branch June 23, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchiu hwchiu hwchiu approved these changes

@chenyunchen chenyunchen chenyunchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sufuf3 @hwchiu @chenyunchen