Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the example yaml #41

Merged
merged 3 commits into from
Jun 13, 2018
Merged

Update the example yaml #41

merged 3 commits into from
Jun 13, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jun 12, 2018

No description provided.

@codecov
Copy link

codecov bot commented Jun 12, 2018

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files           7        7           
  Lines         182      182           
=======================================
  Hits          158      158           
  Misses         15       15           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fb13ae...b91b832. Read the comment docs.

@sufuf3
Copy link
Contributor

sufuf3 commented Jun 12, 2018

Hi guys,
Maybe we can move the file example/kubernetes/clientpodtest.yaml into a deploy/client/ folder.
What do you think?

Thank you very much.

@hwchiu
Copy link
Contributor Author

hwchiu commented Jun 12, 2018

Since that yaml is a testing yaml for client, I think we should put it under xxxx/example. maybe deploy/client/example and we should also add a READEME.md to describe how to use it.

@John-Lin John-Lin merged commit 962169a into master Jun 13, 2018
@John-Lin John-Lin deleted the hwchiu/example branch June 13, 2018 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants