[WIP] Alex/modify flow #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchiu
reviewed
Jun 1, 2018
ovs/ovs_test.go
Outdated
| assert.NoError(t, err) | ||
| assert.Equal(t, 0, len(flows)) | ||
|
|
||
| defer c.VSwitch.DeleteBridge(bridgeName) |
There was a problem hiding this comment.
change this to line 50.
創立完畢後馬上接這個，放在最後有可能會中間就有錯誤，沒有正常跑到這行
chenyunchen
force-pushed
the
alex/ModifyFlow
branch
from
925e989
to
8af00af
Compare
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
===========================================
+ Coverage 20% 46.15% +26.15%
===========================================
Files 1 1
Lines 15 52 +37
===========================================
+ Hits 3 24 +21
- Misses 11 22 +11
- Partials 1 6 +5
Continue to review full report at Codecov.
|
chenyunchen
force-pushed
the
alex/ModifyFlow
branch
from
0ee45ea
to
c74f965
Compare
chenyunchen
force-pushed
the
alex/ModifyFlow
branch
from
ff855dd
to
755c4b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.