Add client set container interface ip gateway #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=======================================
Coverage 86.81% 86.81%
=======================================
Files 7 7
Lines 182 182
=======================================
Hits 158 158
Misses 15 15
Partials 9 9Continue to review full report at Codecov.
|
John-Lin
suggested changes
Jun 12, 2018
client/main.go
Outdated
| @@ -82,8 +82,23 @@ func main() { | |||
| log.Fatalf("There is something wrong with connect bridge: %v", err) | |||
| } | |||
| if b.Success { | |||
| log.Printf("Connecting bridge is sussessful. The reason is %s.", b.Reason) | |||
| log.Printf("Connecting bridge is sussessful.") | |||
| } else { | |||
| log.Printf("Connecting bridge is not sussessful. The reason is %s.", b.Reason) | |||
There was a problem hiding this comment.
should break here
log.Fatalf("Connecting bridge is not sussessful. The reason is %s.", b.Reason)
chenyunchen
force-pushed
the
alex/ClientSetIP
branch
from
e14d9eb
to
86143e7
Compare
hwchiu
suggested changes
Jun 12, 2018
client/main.go
Outdated
| } else { | ||
| log.Printf("Connecting bridge is not sussessful. The reason is %s.", b.Reason) | ||
| } | ||
|
|
There was a problem hiding this comment.
Please rebase and call this function if and only if setIP is true
John-Lin
approved these changes
Jun 12, 2018
hwchiu
approved these changes
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.