Fix OVS Interface Name #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John-Lin
reviewed
Jun 6, 2018
server/netlink_handler.go
Outdated
| @@ -65,7 +65,7 @@ func (s *server) ConnectBridge(ctx context.Context, req *pb.ConnectBridgeRequest | |||
| }, err | |||
| } | |||
|
|
|||
| hostVethName := utils.GenerateVethName(req.PodUUID) | |||
| hostVethName := utils.GenerateVethName(req.PodUUID + req.ContainerVethName) | |||
There was a problem hiding this comment.
Fix the OVS side link problem that all the veth's name is same.
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=======================================
Coverage 85.03% 85.03%
=======================================
Files 5 5
Lines 127 127
=======================================
Hits 108 108
Misses 12 12
Partials 7 7
Continue to review full report at Codecov.
|
c9s
approved these changes
Jun 6, 2018
|
Please check the limitation of the veth name. since the interface name usually contains [0-9a-zA-Z-_] |
chenyunchen
force-pushed
the
alex/FixOVSInterfaceName
branch
from
0d132e2
to
76592f6
Compare
chenyunchen
force-pushed
the
alex/FixOVSInterfaceName
branch
from
76592f6
to
ccdb356
Compare
John-Lin
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.