Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the openvswitch directory #14

Merged
merged 6 commits into from
Jun 5, 2018
Merged

Refactor the openvswitch directory #14

merged 6 commits into from
Jun 5, 2018

Conversation

hwchiu
Copy link
Contributor

@hwchiu hwchiu commented Jun 5, 2018

  • Create a new object OVSManager and it contains the ovs.Client object.
  • All the OVS function is a member function of OVSManager, hence we only init the ovs.Client once for a series OVS operation
  • The server side object server contains the OVSManager

@codecov
Copy link

codecov bot commented Jun 5, 2018

Codecov Report

Merging #14 into master will increase coverage by 4.46%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   75.21%   79.67%   +4.46%     
==========================================
  Files           4        5       +1     
  Lines         117      123       +6     
==========================================
+ Hits           88       98      +10     
+ Misses         20       18       -2     
+ Partials        9        7       -2
Impacted Files Coverage Δ
openvswitch/ovs.go 100% <100%> (+7.69%) ⬆️
utils/utils.go 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0db9fd3...10143fa. Read the comment docs.

@hwchiu hwchiu requested review from chenyunchen and John-Lin and removed request for chenyunchen June 5, 2018 06:07
@hwchiu hwchiu merged commit 1580421 into master Jun 5, 2018
@hwchiu hwchiu deleted the hwchiu/fix-vet branch June 5, 2018 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants