-
Notifications
You must be signed in to change notification settings - Fork 216
feat(blog): Republish Protocol Detection blog by Nawaz Dhandala #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CathPag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
travisbeckham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
One question... did you mean to add the PSD source files to the PR? Up to this point, we haven't stored these files in the website repo.
|
I added the PSDs intentionally because I realized that it felt silly to have a bunch of random Photoshop files on my laptop, but I could be convinced that we should just throw them away, too (or that we should, say, switch to the Affinity suite). |
|
I would just advocate for having these all in the same place, where ever that is (I just assumed Marketing had a place for source assets, but maybe that's not the case). Because some of these PSD files could be rather large, and they will mostly likely not be used again, I think it would make sense to keep them outside the repo but available to everyone who puts together marketing materials. It's your call though! If github makes the most sense to you, that works for me. |
Signed-off-by: Flynn <flynn@buoyant.io>
Signed-off-by: Flynn <flynn@buoyant.io>
18cb53b to
b8d28dc
Compare
|
@travisbeckham, I thought about it and agree with you. 😂 I moved the PSDs into a Drive folder and yanked 'em from here. |
Signed-off-by: Flynn flynn@buoyant.io