Stop special-casing conduit controller in Grafana#984
Merged
Conversation
klingerf
reviewed
May 23, 2018
Contributor
klingerf
left a comment
klingerf
left a comment
There was a problem hiding this comment.
Looks good -- I just had one comment about the datasource for the new dashboard.
| "bars": false, | ||
| "dashLength": 10, | ||
| "dashes": false, | ||
| "datasource": "${DS_PROMETHEUS}", |
Contributor
There was a problem hiding this comment.
I think that throughout this file you'll need to use:
"datasource": "prometheus",
Otherwise I see this when I navigate to this dashboard:
9 tasks
klingerf
approved these changes
May 23, 2018
Contributor
klingerf
left a comment
klingerf
left a comment
There was a problem hiding this comment.
⭐️ Great, thanks for updating.
The Grafana dashboards were explicitly filtering out Conduit control-plane data. Remove control-plane filtering from Grafana dashboards. This brings Grafana in-line with web, and also encourages better dog-fooding of our proxy metrics and dashboards. Also update Grafana to 5.1.3, update the BUILD.md architecture diagram to include Promethues and Grafana, and introduce a Prometheus Benchmark dashboard, courtesy of Robust Perception. Fixes #908 Signed-off-by: Andrew Seigner <siggy@buoyant.io>
siggy
force-pushed
the
siggy/conduit-in-your-grafana
branch
from
7037b9c to
4838c24
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Grafana dashboards were explicitly filtering out Conduit
control-plane data.
Remove control-plane filtering from Grafana dashboards. This brings
Grafana in-line with web, and also encourages better dog-fooding of our
proxy metrics and dashboards. Also update Grafana to 5.1.3, update the
BUILD.md architecture diagram to include Promethues and Grafana, and
introduce a Prometheus Benchmark dashboard, courtesy of Robust
Perception.
Fixes #908
Signed-off-by: Andrew Seigner siggy@buoyant.io