Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit event when skipping mirroring of a service #7655

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

adleong
Copy link
Member

@adleong adleong commented Jan 20, 2022

Follow up to #7597

Emit an event when service mirroring is skipped due to the namespace not existing in the source cluster.

Signed-off-by: Alex Leong alex@buoyant.io

Signed-off-by: Alex Leong <alex@buoyant.io>
@adleong adleong requested a review from a team as a code owner January 20, 2022 19:35
Copy link
Member

@olix0r olix0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How hard is it to test that these events are emitted?

Signed-off-by: Alex Leong <alex@buoyant.io>
@adleong adleong merged commit af4a686 into main Jan 21, 2022
@adleong adleong deleted the alex/skip-namespace-events branch January 21, 2022 17:27
olix0r pushed a commit that referenced this pull request Apr 13, 2022
Follow up to #7597

Emit an event when service mirroring is skipped due to the namespace not existing in the source cluster.

Signed-off-by: Alex Leong <alex@buoyant.io>
(cherry picked from commit af4a686)
Signed-off-by: Oliver Gould <ver@buoyant.io>
olix0r pushed a commit that referenced this pull request Apr 14, 2022
Follow up to #7597

Emit an event when service mirroring is skipped due to the namespace not existing in the source cluster.

Signed-off-by: Alex Leong <alex@buoyant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants