-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!(helm): Add installGatewayAPI helm chart value #13739
Conversation
Signed-off-by: Alex Leong <alex@buoyant.io>
charts/linkerd-crds/templates/gateway.networking.k8s.io_grpcroutes.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
Signed-off-by: Alex Leong <alex@buoyant.io>
While testing I see the helm chart installs by default the CRDs while the CLI doesn't. Is that expected?
|
@alpeb yes this is expected. In Helm's default mode, it doesn't differentiate between install and upgrade for template rendering, so in the short term we still include the gateway API CRDs by default. On the Linkerd CLI side, we can be more intelligent and skip the gateway API CRDs by default for new installs or for upgrades when the gateway API CRDs are not already installed by Linkerd. |
Signed-off-by: Alex Leong <alex@buoyant.io>
…into alex/gateway-off
We add a new value to the
linkerd-crds
Helm chart calledinstallGatewayAPI
which acts as a default value forenableHttpRoutes
,enableTlsRoutes
, andenableTcpRoutes
. We also update the logic of thelinkerd install
andlinkerd upgrade
commands to set thisinstallGatewayAPI
value to true if there are any gateway API CRDs managed by Linkerd on the cluster and false otherwise. Users can still override this setting by specifying the--set installGatewayAPI=(false|true)
flag.This is all to move us toward the eventual goal of having the Gateway API CRDs treated as an external dependency rather than being managed by Linkerd without breaking the upgrade path.