refactor(app/gateway): extract spawn_routes() function
#4125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a follow-on to #4119. see #4119 (comment) for further background on this: > This is reaching unreadable levels of complexity imo. > > i'd look to trying to golf this down so that we don't have so many > wrapping lines, or otherwise extract this into a separate function so > it is, e.g. `push_filter(spawn_routes)` this commit performs that transformation, outlining our `push_filter(|| {})` into a standalone function rather than an inline closure. Signed-off-by: katelyn martin <kate@buoyant.io>
sfleen
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a follow-on to #4119.
see #4119 (comment)
for further background on this:
this commit performs that transformation, outlining our
push_filter(|| {})into a standalone function rather than an inlineclosure.
Signed-off-by: katelyn martin kate@buoyant.io