xxx(app/inbound): inbound metrics prototype #4121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
changed the title
cratelyn
commented
Aug 29, 2025
Member
Author
There was a problem hiding this comment.
todo; these changes are likely unnecessary
cratelyn
commented
Aug 29, 2025
Comment on lines
+43
to
+49
| // XXX(kate): `Param<T>` stubs for labels we can potentially introduce. | ||
| let policy: crate::policy::AllowPolicy = target.param(); | ||
| let _: http::Variant = target.param(); | ||
| let _: Remote<ServerAddr> = target.param(); | ||
| let _: Remote<ClientAddr> = target.param(); | ||
| let _: tls::ConditionalServerTls = target.param(); | ||
| let _: crate::policy::AllowPolicy = target.param(); |
Member
Author
There was a problem hiding this comment.
todo; sift through which fields here are worth using as labels for the request count families.
Base automatically changed from
kate/app-inbound.permitted-target-type
to
main
September 2, 2025 18:45
Signed-off-by: katelyn martin <kate@buoyant.io>
cratelyn
force-pushed
the
kate/app-inbound.prototype-metrics-layer
branch
from
3c82ede to
60e3c6b
Compare
Member
Author
|
this prototype branch is superseded by #4127. i am going to close this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: this branch is based upon these prerequisite changes...
Permitted<T>target #4119