-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route requests to original dsts when no endpoints exist in the lb #240
Closed
Closed
Changes from 18 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
aeb967f
Replace linkerd2-stack with tower-layer
seanmonstar 5576d78
Add "no endpoints" state to resolve::Discover
hawkw d20b5c2
Hack destination_set to send NoEndpoints
hawkw 933581d
wire up endpoint status *without* breaking stuff
hawkw 3d358d0
don't get discover out of stack
hawkw f731f56
add no-endpoints error
hawkw 2a24588
wip
hawkw facf313
start adding tests
hawkw ef838d6
made the tests compile but the proxy still doesn't
hawkw 0c152a4
Merge branch 'master' into liza/balance-rt-good
hawkw dad8ad9
thanks @seanmonstar
hawkw 11f8578
fix payload err types
hawkw 6c14ac1
make everything compile-y
hawkw c87b088
fix fallback svc being ready when the LB isn't
hawkw 7069c1d
fix warnings in tests
hawkw f7abd4e
clean up balancer construction a bit
hawkw 741debd
Merge branch 'master' into liza/balance-rt-good
hawkw 4f1abf2
turn warnings back on
hawkw 9768683
rm vestigial where bounds
hawkw 02628b3
simplify fallback router's `recognize` closure
hawkw 6a34871
create balancer and/or router as needed
hawkw 646728d
keep balancer alive always to drive discovery
hawkw d00858f
Merge branch 'master' into liza/balance-rt-good
hawkw 767b8c6
rm buffers
hawkw 6ac0715
use single-slot buffer for the router
hawkw ae22014
rm unused service impl
hawkw 68e1814
replace MakeCurried , convey intent better
hawkw 00d0c47
Revert "use single-slot buffer for the router"
hawkw 19cda74
poll router when it exists
hawkw 5736498
Merge branch 'master' into liza/balance-rt-good
hawkw b34cd1d
also fix syntax
hawkw 5d44601
always send NoEndpoints
hawkw 3d500f1
fix bad merge
hawkw 378f9d7
fix bad merge
hawkw e24f5fe
add logging to fallback
hawkw 4c75002
fix fallback router never being ready
hawkw 3c2fb23
don't assume no endpoints
hawkw 8130e8d
Merge branch 'master' into liza/balance-rt-good
hawkw fb99e9f
Remove test asserting no eps times out
hawkw ca64d98
Replace test with one expecting the right behavior
hawkw 8cc4d78
Merge branch 'master' into liza/balance-rt-good
hawkw ea1b74a
remove target type parameter from `pending::layer`
hawkw 433505b
put fallback module in its own file
hawkw 599201a
only update fallback state in `poll_ready`
hawkw b565ae6
compose fallback using ServiceBuilder
hawkw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type annotation is necessary as a result of changing the
pending::layer
function to bound the target type.