Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: Implement FmtMetrics for Option #1302

Merged
merged 2 commits into from
Oct 7, 2021
Merged

metrics: Implement FmtMetrics for Option #1302

merged 2 commits into from
Oct 7, 2021

Commits on Oct 7, 2021

  1. metrics: Implement FmtMetrics for Option 

    Some metrics are globally enabled/disabled from being emitted. In this
case, it's useful to simply return an optional implementnation of
`FmtMetrics`. This change implements `FmtMetrics` for `Option` so
implementations (like identity metrics) need not encode this state
internally.

To accomodate this `FmtMetrics::and_then` has been renamed to
`FmtMetrics::and_then_report` to avoid conflicting with
`Option::and_then`.
    @olix0r
    olix0r committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    6c04942 View commit details
    Browse the repository at this point in the history

  2. and_then_report => and_report

    @olix0r
    olix0r committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    9a80207 View commit details
    Browse the repository at this point in the history