Skip to content

Commit

Permalink
Log discovery changes at DEBUG (#1340)
Browse files Browse the repository at this point in the history
It seems that we no longer log specific discovery changes at DEBUG
anywhere. We probably ought to revisit the discovery pipeline more
holistically and ensure that we're logging in strategic places, but for
now this will help users diagnose discovery updates without subscribing
to the much noisier TRACE stream.

Relates to linkerd/linkerd2#6842

(cherry picked from commit ded8c6c)
Signed-off-by: Oliver Gould <ver@buoyant.io>
  • Loading branch information
olix0r committed Mar 30, 2022
1 parent a428c06 commit 732d2e9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions linkerd/proxy/discover/src/from_resolve.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ use std::{
task::{Context, Poll},
};
use tower::discover::Change;
use tracing::trace;
use tracing::{debug, trace};

#[derive(Clone, Debug)]
pub struct FromResolve<R, E> {
Expand Down Expand Up @@ -106,7 +106,7 @@ where
loop {
let this = self.as_mut().project();
if let Some(change) = this.pending.pop_front() {
trace!(?change, "Changed");
debug!(?change, "Changed");
return Poll::Ready(Some(Ok(change)));
}

Expand Down

0 comments on commit 732d2e9

Please sign in to comment.