-
Notifications
You must be signed in to change notification settings - Fork 268
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
dns-name: Remove
webpki
dependency (#1316)
The `dns::Name` type is backed by `webpki::DNSName`; and the `webpki` crate has a dependency on `ring`. As we setup to support alternate cryptographic implementations, we don't want to incur this dependency for such a simple type that only validates DNS-like names. This change copies the `webpki::DNSName` and `webpki::DNSNameRef` types as `dns::Name` and `dns::NameRef` (preserving copyright information). Name parsing is simplified, as we don't need to handle wildcards with these types. Furthermore, this change updates the various identity-type wrapper types to implement `Deref` so that `dns::Name::as_str` and `dns::Name::as_bytes` are available implicitly. (cherry picked from commit 27587f5) Signed-off-by: Oliver Gould <ver@buoyant.io>
- Loading branch information
Showing
15 changed files
with
352 additions
and
119 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -895,7 +895,6 @@ version = "0.1.0" | |
dependencies = [ | ||
"thiserror", | ||
"untrusted", | ||
"webpki", | ||
] | ||
|
||
[[package]] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,4 +9,3 @@ publish = false | |
[dependencies] | ||
thiserror = "1.0" | ||
untrusted = "0.7" | ||
webpki = "0.21" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.