added rule 3.1.16 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -473,6 +473,8 @@ do { | |||
|
|
|||
| * **3.1.15** If you have a function that takes no arguments, has no side effects, and returns some object or value, prefer using a computed property instead. | |||
|
|
|||
| * **3.1.16** For the purpose of namespacing a set of `static` functions and/or computed properties, prefer using a caseless `enum` over a `class` or a `struct`. This way, you don't have to add a `private init() { }` to the container. | |||
There was a problem hiding this comment.
maybe repeat the word static again. It seems not quite clear whether static refers to "functions" only or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See diff for new rule.
I ran tests to confirm that using an
enumas astaticfunction container is actually faster + produces a smaller binary than using aclass. Astructis actually just slightly better in this regard, but the difference is very small, and the added benefit of not being able to instantiate the container is arguably worth it.