Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added rules 3.1.14 and 3.1.15 #4

Merged
merged 1 commit into from
Aug 28, 2016
Merged

added rules 3.1.14 and 3.1.15 #4

merged 1 commit into from
Aug 28, 2016

Conversation

cezarywojcik
Copy link
Member

@cezarywojcik cezarywojcik commented Aug 28, 2016 •
edited
Loading

See diff for new rules.

Preferring static to class for several reasons:

  1. Static dispatch is technically faster than dynamic dispatch
  2. Given the above, it makes sense to pick static over class so that we consistently use one over the other.
  3. This way, usage of class will indicate that the intent of that function is to be overridden, which can be useful information at-a-glance.

@drumnkyle drumnkyle merged commit 923745d into linkedin:master Aug 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cezarywojcik @drumnkyle