Property-Variable Fixes #3
Conversation
|
@cezarywojcik take a look and see if you agree. |
| @@ -51,7 +51,7 @@ class SomeClass { | |||
| } | |||
| ``` | |||
|
|
|||
| * **1.6** When writing a type for a property, a key for a dictionary, a function argument, a protocol conformance, or a superclass, don't add a space before the colon. | |||
| * **1.6** When writing a type for a property, contant or variable, a key for a dictionary, a function argument, a protocol conformance, or a superclass, don't add a space before the colon. | |||
There was a problem hiding this comment.
- spelling: contant -> constant
- I'd just write it as "... property, constant, variable, a key ..."
| @@ -147,7 +147,7 @@ someFunctionWithABunchOfArguments( | |||
| }) | |||
| ``` | |||
|
|
|||
| * **1.12** Prefer using local properties or other mitigation techniques to avoid multi-line predicates where possible. | |||
| * **1.12** Prefer using local variables or constants or other mitigation techniques to avoid multi-line predicates where possible. | |||
There was a problem hiding this comment.
super-minor: I'd put constant first ("constants or variables") or maybe even just "constants" here. shouldn't have to use variables for broken-up predicates I think.
There was a problem hiding this comment.
Good point. I'll change it now.
|
@cezarywojcik Comment here when you are done reviewing, so I know. |
| @@ -379,7 +379,7 @@ for integer in [4, 8, 15, 16, 23, 42] { | |||
| } | |||
| ``` | |||
|
|
|||
| * **3.1.3** Prefer not declaring types for properties or constants if they can be inferred anyway. | |||
| * **3.1.3** Prefer not declaring types for properties, constants, or variables if they can be inferred anyway. | |||
There was a problem hiding this comment.
As above, do you think we need to list properties here if we already mentioned both variables and constants? I think that the original distinction here was a somewhat misworded one between instance variables and "static constants", but variables + constants cover those.
There was a problem hiding this comment.
For this one, I will agree and will leave it as constants and variables.
|
@drumnkyle Let's also change the Also of note from the above: we have outdated syntax for LGTM after that. |
No description provided.