Repository navigation
Fix entry point parsing for plugin names containing colons - #284
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking up a console script fails with
DuplicateOptionErrorwhen another entry-point group contains names such as{:.5f}and{:2.3e}. The defaultConfigParsertreats the colon as a delimiter and reads both names as{.Use only
=as the delimiter, preserving colon-containing names while retaining duplicate detection. The regression test includes two formatter entries alongside an unrelated console script and verifies that the script can be resolved.Fixes #253. The reproduction and approach were posted on the issue before this PR.
Validation on Linux with Python 3.11.15:
DuplicateOptionErrorbefore the fix and passes after it.PYTHONPATH=src python -m pytest -o addopts= test -q— 60 passed.mypy src/— passed (12 source files).flake8 src/ test/— passed.An initial Python 3.12 run had 57 passes and 3 failures, including two caused by an interpreter path exceeding the shebang limit. The clean supported-version run above uses a shorter interpreter path.
Prepared with Codex assistance, including the implementation, regression test, and this description.