Skip to content

Expose building an archive as an API #36

Description

@moshez

I have a wrapper for building executables that I would like to move from pex to shiv. However, the API to build executables is not exposed. It seems like starting around the with Temporary.... would be a good place to split up and call an API function.

Would that make sense as a PR?

Activity

  1. moshez commented on Jun 7, 2018

    @moshez
    Author
  2. lorencarvalho commented on Jun 7, 2018

    @lorencarvalho
    Contributor

    hi @moshez !

    this would be a welcome contribution, (or I'd be happy to take a crack at it as well). I think stylistically it'd be best to move everything except the click entrypoint out of cli.py and into it's own module. I'd suggest builder.py but I'd like to keep that untouched since the logic there is cribbed from zipapp (so I don't want to clutter it), perhaps builder.py could be renamed zipapp.py and then the archive creation functions could be placed into a builder.py?

  3. warsaw commented on Jun 8, 2018

    @warsaw

    No need to CC me, I get all notifications. Oh, and +1!

  4. moshez commented on Jun 8, 2018

    @moshez
    Author

    Sounds good, I should have some time next week to prototype a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions