Add support to send feedback title for bottomsheet flow #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In bottomsheet flow, users can choose between `Report a bug` and `Send app feedback`. Per previous flow it was mandatory to send title that would identify which option was being selected in the bottomsheet. Currently, only attachments are bring sent in `safeResult` and title field is empty. Support Added: - Added support `BottomSheetFeedbackItem#getTitleResId` to get title based on `BottomSheetFeedbackItem` feedback type. - Added a new key `BottomSheetFeedbackTypeAdapter#EXTRA_FEEDBACK_TITLE` to pass the value of title in intent using the newly added method. - Added support to fetch the value of feedback title when bottomsheet flow is active upon receiving the broadcast in `Shaky#createReceiver`. - Further, support added to set value of title in `safeResult` to submit it in feedback. - Also, removed the key ‘BottomSheetFeedbackTypeAdapter#EXTRA_FEEDBACK_TYPE’ as it has no usage in the bottomsheet flow.
li-advait
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Report a bugandSend app feedback.Form/Drawscreen as per option selected in bottomsheet), it was required to send title that would identify which option is being selected in the bottomsheet.Result, while no value is set for the title field.Support Added:
BottomSheetFeedbackItem#getTitleResIdto get title based onBottomSheetFeedbackItemfeedback type.BottomSheetFeedbackTypeAdapter#EXTRA_FEEDBACK_TITLEto pass the value of title in intent using the newly added method.Shaky#createReceiver.safeResult.setTitle, before the result is submitted.BottomSheetFeedbackTypeAdapter#EXTRA_FEEDBACK_TYPEas it has no usage in the bottomsheet flow.Testing Done