Add support to perform custom action in feedback dialog #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 23, 2025 19:05
- Added support in SendFeedbackDialog to start custom flow on positive button click of the dialog. - Added action ACTION_START_BUG_REPORT to start the Report a Bug flow directly. - Added support in Shaky class to start the provided flow. - Updated FeedbackActivity to directly launch the Bug Report screen when required. - Added "Manually start bug report" button in sample app to test the ACTION_START_BUG_REPORT action manually in shaky.
li-manssing
changed the title
advait8
reviewed
Feb 4, 2025
shaky/src/main/java/com/linkedin/android/shaky/FeedbackActivity.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SendFeedbackDialogto start custom flow on positivebutton click of the dialog.
ACTION_START_BUG_REPORTto start the "Report a Bug" flowdirectly.
Shakyclass to start the provided flow.FeedbackActivityto directly launch the Bug Report screenwhen required.
ACTION_START_BUG_REPORTaction manually in shaky.Testing Done
Tested locally. Please refer the screen-recordings below:
before.mp4
shaky_after.mp4