Fix type erasure warnings in files not scheduled to be removed by other commits #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmjiang @yunboouyang @lguo |
ashelkovnykov
force-pushed
the
noWarnings
branch
3 times, most recently
from
c0ba126 to
ec8764b
Compare
|
@cmjiang @yunboouyang @lguo |
ashelkovnykov
commented
May 20, 2020
| val scoringPartitions: Param[Int] = ParamUtils.createParam( | ||
| "scoring partitions", | ||
| "Number of partitions to use for the data being scored", | ||
| ParamValidators.gt[Int](0.0)) |
There was a problem hiding this comment.
Forgot to add new parameter to SCOPT
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.