Remove hyperparmeter tuning code #454
Conversation
ashelkovnykov
commented
Feb 14, 2020
ashelkovnykov
commented
- Photon team at LinkedIn has continued to work on hyperparameter tuning code
- Working on releasing it as a separate open source project
- Until then, removing the old version which was available but unused
| * @param transformMap A Map with key-value pairs of indices and names of transform functions. | ||
| * @return The transformed vector. | ||
| */ | ||
| def transformForward( |
There was a problem hiding this comment.
Why do we delete this function? Our internal atlas-ml does not have functions to perform parameter transformation.
There was a problem hiding this comment.
Let's wait to merge this PR until the internal dependency changes.
There was a problem hiding this comment.
@yunboouyang @cmjiang
I don't understand this comment - are these two functions not available in the internal hyperparameter tuning library? Is there a blocker to copying the implementation over from here?
There was a problem hiding this comment.
The reason to leave these two functions in Photon ML is that, we wanted to do the same transformation in Photon ML. Photon ML doesn't have the dependency on the internal hyperparameter tuning library. If Photon ML doesn't need to reuse these functions, we can move it to the tuning library.
| * @param transformMap A Map with key-value pairs of indices and names of transform functions. | ||
| * @return The transformed vector. | ||
| */ | ||
| def transformBackward( |
There was a problem hiding this comment.
I have the same concern here.
There was a problem hiding this comment.
See above please
| * @throws IllegalAccessException | ||
| */ | ||
| def apply(className: String): HyperparameterTuner[GameEstimator.GameResult] = | ||
| Class.forName(className) |
There was a problem hiding this comment.
How do users specify the class name? Do they need to specify the full class path "com.linkedin.atlas.tuner.AtlasTuner"?
There was a problem hiding this comment.
That's right - full class path.
.../src/main/scala/com/linkedin/photon/ml/io/scopt/game/ScoptGameTrainingParametersParser.scala
Outdated
Show resolved
Hide resolved
- Photon team at LinkedIn has continued to work on hyperparameter tuning code - Working on releasing it as a separate open source project - Until then, removing the old version which was available but unused
3 participants
