Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten DLO strategy object into separate compaction args #230

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Flatten DLO strategy object into separate compaction args #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions ...ava/com/linkedin/openhouse/jobs/scheduler/tasks/TableDataLayoutStrategyExecutionTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
package com.linkedin.openhouse.jobs.scheduler.tasks;

import com.linkedin.openhouse.datalayout.persistence.StrategiesDaoTableProps;
import com.linkedin.openhouse.datalayout.config.DataCompactionConfig;
import com.linkedin.openhouse.jobs.client.JobsClient;
import com.linkedin.openhouse.jobs.client.TablesClient;
import com.linkedin.openhouse.jobs.client.model.JobConf;
import com.linkedin.openhouse.jobs.util.TableDataLayoutMetadata;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Objects;

public class TableDataLayoutStrategyExecutionTask
extends TableOperationTask<TableDataLayoutMetadata> {
Expand All @@ -25,11 +27,28 @@ public JobConf.JobTypeEnum getType() {

@Override
protected List<String> getArgs() {
return Arrays.asList(
"--tableName",
metadata.fqtn(),
"--strategy",
StrategiesDaoTableProps.serialize(metadata.getDataLayoutStrategy()));
DataCompactionConfig config = metadata.getDataLayoutStrategy().getConfig();
List<String> args =
new ArrayList<>(
Arrays.asList(
"--tableName",
metadata.fqtn(),
"--targetByteSize",
Objects.toString(config.getTargetByteSize()),
"--minByteSizeRatio",
Objects.toString(config.getMinByteSizeRatio()),
"--maxByteSizeRatio",
Objects.toString(config.getMaxByteSizeRatio()),
"--minInputFiles",
Objects.toString(config.getMinInputFiles()),
"--maxConcurrentFileGroupRewrites",
Objects.toString(config.getMaxConcurrentFileGroupRewrites())));
if (config.isPartialProgressEnabled()) {
args.add("--partialProgressEnabled");
args.add("--partialProgressMaxCommits");
args.add(Objects.toString(config.getPartialProgressMaxCommits()));
}
return args;
}

@Override
Expand Down
Loading