Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null check for partition value. #200

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

anjagruenheid
Copy link
Collaborator

@anjagruenheid anjagruenheid commented Sep 18, 2024

Summary

Issue] Briefly discuss the summary of the changes made in this
pull request in 2-3 lines.

Changes

  • Client-facing API Changes
  • Internal API Changes
  • Bug Fixes
  • New Features
  • Performance Improvements
  • Code Style
  • Refactoring
  • Documentation
  • Tests

For all the boxes checked, please include additional details of the changes made in this pull request.

Testing Done

  • Manually Tested on local docker setup. Please include commands ran, and their output.
  • Added new tests for the changes made.
  • Updated existing tests to reflect the changes made.
  • No tests added or updated. Please explain why. If unsure, please feel free to ask for help.
  • Some other form of testing like staging or soak time in production. Please explain.

For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.

Additional Information

  • Breaking Changes
  • Deprecations
  • Large PR broken into smaller PRs, and PR plan linked in the description.

For all the boxes checked, include additional details of the changes made in this pull request.

Copy link
Collaborator

@sumedhsakdeo sumedhsakdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anja for the bug fix. Can we add a unit test that fails with this bug prior to fix and passes after the fix.

sumedhsakdeo
sumedhsakdeo previously approved these changes Sep 18, 2024
Copy link
Collaborator

@sumedhsakdeo sumedhsakdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anja. LGTM. Small nit: please update the description section Testing Done.

Copy link
Collaborator

@teamurko teamurko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for adding a unit-test! can we use Objects.toString, it handles null

@anjagruenheid
Copy link
Collaborator Author

lgtm, thank you for adding a unit-test! can we use Objects.toString, it handles null

Integrated, thanks for the review!

teamurko
teamurko previously approved these changes Sep 23, 2024
@anjagruenheid anjagruenheid merged commit c6e4d1e into linkedin:main Sep 24, 2024
1 check passed
@anjagruenheid anjagruenheid deleted the partition_nullcheck branch September 24, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants