-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Null check for partition value. #200
Null check for partition value. #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Anja for the bug fix. Can we add a unit test that fails with this bug prior to fix and passes after the fix.
...talayout/src/main/java/com/linkedin/openhouse/datalayout/datasource/TablePartitionStats.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Anja. LGTM. Small nit: please update the description section Testing Done.
...talayout/src/main/java/com/linkedin/openhouse/datalayout/datasource/TablePartitionStats.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thank you for adding a unit-test! can we use Objects.toString, it handles null
Integrated, thanks for the review! |
c81675b
to
77b0705
Compare
8600f77
to
e2de5f4
Compare
Summary
Issue] Briefly discuss the summary of the changes made in this
pull request in 2-3 lines.
Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.