Add release on tag for circleci #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radai-rosenblatt
force-pushed
the
master
branch
from
780d341 to
c8eb272
Compare
|
LGTM. The only thing that you might want to add is some check that the version gradle knows about is also the version used in the tag. Since this in the gradle.properties file it should be straight forward to extract this from gradle.properties. |
radai-rosenblatt
force-pushed
the
master
branch
from
c8eb272 to
dfd2571
Compare
|
now with 60% more regexp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs - https://circleci.com/docs/2.0/workflows/#git-tag-job-execution