Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release of 0.5.0 #103

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Release of 0.5.0 #103

merged 4 commits into from
Apr 4, 2023

Conversation

njusu
Copy link
Contributor

@njusu njusu commented Apr 3, 2023

Release of greykite 0.5.0!

al-bert
al-bert reviewed Apr 3, 2023
View reviewed changes
Copy link
Contributor

@al-bert al-bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update AUTHORS.rst and HISTORY.rst as well? (separate commit is fine)

@njusu
Copy link
Contributor Author

njusu commented Apr 4, 2023

Could you update AUTHORS.rst and HISTORY.rst as well? (separate commit is fine)

@al-bert Sure, I updated them. The hyperlinks to doc will not work thus I removed them. After the release is published, we could add the links pointing to the updated doc if needed.

al-bert
al-bert approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@al-bert al-bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

KaixuYang
KaixuYang approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@KaixuYang KaixuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Reza1317
Reza1317 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@Reza1317 Reza1317 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did not spot any issues. Obviously this is a lot to look at and result of many internal reviews. But please have at least two more people review this including Albert Chen.

@njusu njusu merged commit 8c87e36 into master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaixuYang KaixuYang KaixuYang approved these changes

@al-bert al-bert al-bert approved these changes

@Reza1317 Reza1317 Reza1317 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@njusu @Reza1317 @al-bert @KaixuYang