Reduce the number of parameters to the css-blocks helper #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The @css-blocks/glimmer package has a bunch of dependencies that we don't need and is just bloating the installation of @css-blocks/ember.
Changes the way the css-blocks helper is invoked. Instead of passing many arguments representing all the styles and their runtime state, a single serialized JSON value is passed that represents all the styles. the remainder of the arguments are the arguments passed by the author to the various block attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the rewrite of css blocks to emit fewer arguments to the css-blocks helper. There's some preliminary perf results that show that argument passing, which invokes change tracking, is more expensive than you might expect. The hypothesis is that by passing few arguments we can speed up the runtime performance. In this change we pass a stringified JSON object that describes the overall shape of the various css blocks styles keeping the arguments for just the runtime variables and expressions provided by the template author. It remains to be seen whether this is a net savings.