Support intra-broker throttling (replica.alter.log.dirs.io.max.bytes.per.second) #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is an WIP; I will test this feature in our in-house fork (@naver) this week. Stay tuned!! 🙃 |
|
@aswinayyolath @mhratson @jiao-zhangS Could you kindly have a look? We adopted this patch to our in-house distribution and confirmed it works correctly. 🙏 |
…ationThrottledRate
- Add: setLogDirThrottles, setLogDirThrottledRateIfNecessary - Rename: removeReplicationThrottledRateFromBroker → removeThrottledRatesFromBroker
…oker rebalanacing
- Rename: ReplicationThrottleHelper.clearThrottles → clearInterBrokerThrottles
- Add ReplicationThrottleHelper.clearIntraBrokerThrottles
- Executor.intraBrokerMoveReplicas now calls ReplicationThrottleHelper.setLogDirThrottles, ReplicationThrottleHelper.clearIntraBrokerThrottles
dongjinleekr
force-pushed
the
feature/1851
branch
from
4781c13
to
c59c864
Compare
cpaika
approved these changes
Aug 15, 2024
| @@ -1707,6 +1729,11 @@ private void intraBrokerMoveReplicas() { | |||
| waitForIntraBrokerReplicaTasksToFinish(); | |||
| inExecutionTasks = inExecutionTasks(); | |||
| } | |||
|
|
|||
| if (_logDirThrottle != null) { | |||
There was a problem hiding this comment.
for my understanding, why the underscore in the variable names here?
There was a problem hiding this comment.
In consistency with _replicationThrottle.
adkafka
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1851.