Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump all dependenciess with vulnerabilities #2141

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

slaupster
Copy link
Contributor

@slaupster slaupster commented Apr 1, 2024

Bump dependencies for vulnerabilities. I've tried to keep in the major/minor track, using only patch versions where possible, but nimbus-jose-jwt needed to have a minor bump as well to avoid vulnerabilities.

This PR resolves #2140.

@slaupster
Copy link
Contributor Author

resolved conflict with vertx which was bumped in another PR

@aswinayyolath
Copy link
Contributor

@CCisGG could you please review and merge this change?

jettyVersion=9.4.53.v20231009
zookeeperVersion=3.8.4
nettyVersion=4.1.108.Final
jettyVersion=9.4.54.v20240208
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a newer version for jetty, 9.4.54 has a medium one: https://nvd.nist.gov/vuln/detail/CVE-2024-8184
9.4.56.v20240826

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think moving to 9.4.56.v20240826 should be safe

nettyVersion=4.1.100.Final
jettyVersion=9.4.53.v20231009
zookeeperVersion=3.8.4
nettyVersion=4.1.108.Final
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vertx uses 4.1.110 and most of the cases the actually used netty lib version will be that. Would it make sense to upgrade to 4.1.110.Final?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, especially if a major dependency like Vert.x already uses that version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is 4.1.114.Final which doesn't seem to have any CVE

@akatona84 akatona84 mentioned this pull request Nov 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiple fixable vulnerabilities
4 participants