Apply lock at Coordinator class level #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoomula
previously approved these changes
Jan 24, 2024
atoomula
reviewed
Jan 24, 2024
datastream-server/src/main/java/com/linkedin/datastream/server/Coordinator.java
Outdated
Show resolved
Hide resolved
atoomula
reviewed
Jan 24, 2024
datastream-server/src/main/java/com/linkedin/datastream/server/Coordinator.java
Outdated
Show resolved
Hide resolved
atoomula
previously approved these changes
Jan 24, 2024
hshukla
dismissed stale reviews from shrinandthakkar and atoomula
via
f92c00a
atoomula
approved these changes
Jan 24, 2024
amybubu
approved these changes
Jan 24, 2024
shrinandthakkar
approved these changes
Jan 24, 2024
| @@ -3230,6 +3230,7 @@ void testOnSessionExpired(boolean handleNewSession) throws DatastreamException, | |||
| Assert.assertTrue(t != null && t.isAlive()); | |||
| Assert.assertTrue(PollUtils.poll(() -> instance1.getIsLeader().getAsBoolean(), 100, 30000)); | |||
| } | |||
| instance1._coordinatorEventThreadExiting = false; | |||
There was a problem hiding this comment.
interesting that we have to set this explicitly 🤔
There was a problem hiding this comment.
The test do zkExpiry and then handleNewSession and then call stop. So during zkExpiry, we go from false -> true, and during stop if _coordinatorEventThreadExiting stays false, then wait does not occur and creates deadlock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #975 where we used
it was giving lock on the
CoordinatorEventProcessorinstance. However, we need a lock on theCoordinatorclass, hence the notifyAll was not working as expected.This PR fixes the above regression by introducing