Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new class to help log assignments #963

Merged
merged 12 commits into from
Nov 14, 2023
Merged

Added new class to help log assignments #963

merged 12 commits into from
Nov 14, 2023

Conversation

amybubu
Copy link
Collaborator

@amybubu amybubu commented Oct 23, 2023 •
edited
Loading

Summary

Added class AssignmentTaskMapLogger to log assignments one task per log line so that logs stay under 1MB in size. Includes logic for checking if a task is greater than 1MB. If it is, that task will be split and logged in multiple parts.

BUG=DATAPIPES-27351

Testing Done

./gradlew build

In unit tests, the time it took to do logAssignment was always <50ms.

@shrinandthakkar
Copy link
Collaborator

Overall LGTM, just few minor comments! Thanks @amybubu for making this change!

@amybubu amybubu merged commit dbe45d9 into linkedin:master Nov 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshukla hshukla hshukla approved these changes

@shrinandthakkar shrinandthakkar shrinandthakkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amybubu @shrinandthakkar @hshukla