Fix tests and reduce the overall test execution time #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkn
reviewed
May 25, 2023
.../src/main/java/com/linkedin/datastream/connectors/kafka/AbstractKafkaBasedConnectorTask.java
Show resolved
Hide resolved
datastream-kafka/src/main/java/com/linkedin/datastream/kafka/EmbeddedKafkaCluster.java
Show resolved
Hide resolved
surajkn
approved these changes
Jun 12, 2023
| @@ -91,6 +91,7 @@ | |||
| /** | |||
| * Tests for {@link KafkaMirrorMakerConnectorTask} | |||
| */ | |||
| @Test(singleThreaded = false) | |||
There was a problem hiding this comment.
Should we be doing this in all our test classes?
I thought by default each test was executed in its own thread and run in parallel. Is that not the case ?
jzakaryan
approved these changes
Jun 12, 2023
| @@ -714,7 +725,7 @@ protected void seekToLastCheckpoint(Set<TopicPartition> topicPartitions) { | |||
| Set<TopicPartition> tpWithNoCommits = new HashSet<>(); | |||
| // construct last checkpoint | |||
| topicPartitions.forEach(tp -> getLastCheckpointToSeekTo(lastCheckpoint, tpWithNoCommits, tp)); | |||
| _logger.info("Seeking to previous checkpoints {}", lastCheckpoint); | |||
| _logger.info("Seeking to previous checkpoints {} ", lastCheckpoint); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircleCI result: 24m 17s (reduced by 25%)