Make numTasks read-only metadata property in get datastream #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrinandthakkar
requested changes
May 10, 2021
...ream-server-restli/src/main/java/com/linkedin/datastream/server/dms/DatastreamResources.java
Outdated
Show resolved
Hide resolved
...-restli/src/main/java/com/linkedin/datastream/server/dms/ZookeeperBackedDatastreamStore.java
Outdated
Show resolved
Hide resolved
|
could you check the ci, there's some test failure |
shrinandthakkar
previously approved these changes
May 11, 2021
shrinandthakkar
previously approved these changes
May 11, 2021
shrinandthakkar
approved these changes
May 12, 2021
jzakaryan
approved these changes
May 12, 2021
vmaheshw
added a commit
to vmaheshw/brooklin
that referenced
this pull request
Mar 1, 2022
…#824) numTasks is an additional datastream property which is calculated as part of elastic task count and saves in a separate node in /dms/<datastream>/numTasks. Rest client should be able to expose this information and any user which cache this information and call update to modify some other field should be able to do it. Note: It will be a read-only property and the server will encapsulate how numTasks is stored. For external user, who has no access to zookeeper cannot differentiate between this metadata v/s any other metadata using the get output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numTasksis an additional datastream property which is calculated as part of elastic task count and saves in a separate node in/dms/<datastream>/numTasks. Rest client should be able to expose this information and any user which cache this information and call update to modify some other field should be able to do it.Note: It will be a read-only property and the server will encapsulate how numTasks is stored. For external user, who has no access to zookeeper cannot differentiate between this metadata v/s any other metadata using the get output.