-
Notifications
You must be signed in to change notification settings - Fork 446
Add GLM4.5V support #863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add GLM4.5V support #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for_glm4v_moe for visual blocks
…_for_glm4v_moe for decoder and vision blocks
…xperts in decoder layers
… and update test configurations
…erts in Glm4vMoe and enhance test assertions
…for_glm4v_moe to reference decoder layer attributes
…for_glm4v_moe to reference post_attention_layernorm
…for_glm4v_moe to reference input_layernorm
Contributor
Author
|
@Tcc0403 Modify loss_atol in |
Closed
Collaborator
|
@vvvdwbvvv lgtm, can you fix checkstyle first? |
Contributor
Author
|
@shimizust Thank you, fixed in ae6aac5 |
shimizust
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for GLM4.1V (GLM-4 Vision) models to the Liger Kernel #855
https://huggingface.co/zai-org/GLM-4.5
This model have been merged in huggingface/transformers#39805
Testing Done
Found that
python3 -m pytest test/convergence/bf16/test_mini_models.py -k 'glm4v_moe' -rFhas
AssertionError: [Loss]Number of mismatched elements: 14with
Test result