Fix OutOfMemoryException in self-referential link substitution#47
Open
Fix OutOfMemoryException in self-referential link substitution#47
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #20
- Add infinite loop protection to prevent OutOfMemoryException when processing self-referential link patterns - Implement multiple safeguards: iteration limits, cycle detection, and reasonable bounds checking - Replace uncontrolled memory exhaustion with controlled InvalidOperationException - Add comprehensive test case for the problematic query pattern: ((($i: 1 21)) (($i: $s $t) ($i 20))) - Include simple verification test to demonstrate the fix works correctly Fixes #20: Unable to substitute a link to itself + outgoing link 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #20 where the query
((($i: 1 21)) (($i: $s $t) ($i 20)))was causing anOutOfMemoryExceptiondue to infinite recursion in theLinksExtensions.EnsureCreatedmethod.Root Cause
The issue occurred in
LinksExtensions.EnsureCreatedwhen processing self-referential link patterns. The method'sdo-whileloop would create links infinitely without ever reaching the targetmaxvalue, eventually exhausting system memory.Solution
Added comprehensive infinite loop protection with multiple safeguards:
Instead of crashing with
OutOfMemoryException, the system now throws a controlledInvalidOperationExceptionwith a descriptive error message.Changes Made
LinksExtensions.EnsureCreatedmethod with loop protectionSelfReferencingLinkSubstitution_ShouldNotCauseInfiniteLoopto verify the fixTest Results
The problematic query now either:
InvalidOperationExceptioninstead ofOutOfMemoryException🤖 Generated with Claude Code
Resolves #20