Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use LINGUI_CONFIG env as fallback for extract #932

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

danielkcz
Copy link
Contributor

Tiny fix where macro package is using the LINGUI_CONFIG env while extract command isn't. In the case of different config locations, this is causing problems. I know there is --config for extract, but that means having a path specified in two different ways.

Only thing I am not sure of if the env variable should take precedence over CLI arg. I chose not, but let me know.

@vercel
Copy link

vercel bot commented Jan 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/lingui-js/js-lingui/ibx48jh36
✅ Preview: https://js-lingui-git-fork-fredyc-extract-config-from-env.lingui-js.vercel.app

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #932 (3f4e697) into main (4ad90d4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #932   +/-   ##
=======================================
  Coverage   83.25%   83.25%           
=======================================
  Files          52       52           
  Lines        1571     1571           
  Branches      426      426           
=======================================
  Hits         1308     1308           
  Misses        156      156           
  Partials      107      107           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad90d4...3f4e697. Read the comment docs.

@danielkcz danielkcz changed the title Use LINGUI_CONFIG env as fallback for extract fix: Use LINGUI_CONFIG env as fallback for extract Jan 7, 2021
@semoal
Copy link
Contributor

semoal commented Jan 9, 2021

AWS says this precedence:

If you specify an option by using a parameter on the CLI command line, it overrides any value from either the corresponding environment variable or a profile in the configuration file.

We should go with that =)

@semoal semoal merged commit ce71a8b into lingui:main Jan 13, 2021
@danielkcz danielkcz deleted the extract-config-from-env branch January 13, 2021 16:22
@semoal
Copy link
Contributor

semoal commented Jan 13, 2021

Released in 3.4.0 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants