-
Notifications
You must be signed in to change notification settings - Fork 406
fix: remove unraw dependency #2271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
@yslpn it checks out master (main) in the PR, probably because of the trigger, |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2271 +/- ##
==========================================
- Coverage 77.05% 76.82% -0.24%
==========================================
Files 84 89 +5
Lines 2157 2498 +341
Branches 555 650 +95
==========================================
+ Hits 1662 1919 +257
- Misses 382 463 +81
- Partials 113 116 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…sary match parameter
Description
Replace the
unraw
library with a lightweight custom implementation for decoding escape sequences.unraw
functionality is too redundant and is not used in the code now. We use a regular expression that only finds valid escape sequences. So I propose to use a more lightweight and simple implementation and remove the unraw dependency. This will not change the behavior for the user.Types of changes
Checklist