-
Notifications
You must be signed in to change notification settings - Fork 414
chore: replace chalk with picocolors #2268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather use ora
than nanospinner
which has far fewer downloads, stars, and contributors. picocolors
looks good.
Security: Reduced attack surface with fewer dependencies
This can be misleading. Let's say that we replace popular, trusted dependency A with more lightweight B, which is controlled by one person, and they at some point introduce malicious code. That's a very real possibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather use ora
than nanospinner
which has far fewer downloads, stars, and contributors. picocolors
looks good.
Security: Reduced attack surface with fewer dependencies
This can be misleading. Let's say that we replace popular, trusted dependency A with more lightweight B, which is controlled by one person, and they at some point introduce malicious code. That's a very real possibility.
I agree and understand your skepticism. This could indeed be a problem if the author abandons support and/or becomes malicious. I respect your opinion, so I will roll back the replacement for nanospinner a bit later. To finish with merge picocolors But I want to add a few objections that are worth thinking about.
|
This reverts commit db70d5b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, this looks good but I'll defer to @andrii-bodnar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Also agree with @vonovak points about ora vs nanospiner
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (46.15%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2268 +/- ##
==========================================
- Coverage 77.05% 76.82% -0.24%
==========================================
Files 84 89 +5
Lines 2157 2498 +341
Branches 555 650 +95
==========================================
+ Hits 1662 1919 +257
- Misses 382 463 +81
- Partials 113 116 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🎯 e18e initiative: ecosystem performance optimization
Replace heavy dependencies with lightweight alternatives
📊 Impact
🔄 Changes
✅ Benefits
upd: updated the dependency data, initially I used the wrong tactics and tools for calculation
upd2: revert replace ora with nanospinner