Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to Babel 6 #220

Closed
wants to merge 9 commits into from
Closed

Switch back to Babel 6 #220

wants to merge 9 commits into from

Conversation

tricoder42
Copy link
Contributor

Upgrading to Babel 7 is backward-incompatible change and requires project to update to Babel 7 as well. This causes several bugs when using Babel 6, eg. #171.

Since Babel 7 is still in beta, js-lingui 2.x will use Babel 6 and new version 3.x will use Babel 7. These two releases will coexist in parallel for some time.

@adamgruber
Copy link
Contributor

Hey @tricoder42 I see this has been open for a bit with failing tests. Is there something I can help out with to move this forward?

@tricoder42
Copy link
Contributor Author

@adamgruber Sorry for delay. Yeah, I'm having trouble to configure babel/rollup. For some reason, transform-runtime imports aren't wrapped in _interopRequireDefault which causes errors. Do you have any experience with this?

@tricoder42
Copy link
Contributor Author

@adamgruber Problem seems to be solved with a simple rollup config. I'm waiting for the tests (green locally) and then I'll proceed with release.

@MartinCerny-awin
Copy link
Contributor

It looks like that it can be released.

@tricoder42
Copy link
Contributor Author

I know... I really don't want to screw this up, because it's potentially backward incompatible release for all those using Babel 7 beta. I would like to release 3.0-beta right after, but I don't have release process ready. I guess I'm gonna ship this pig tonight and 3.0-beta soon.

Thank you for patience!

@tricoder42
Copy link
Contributor Author

Released in 2.1.0, thanks everyone for patience!

@tricoder42 tricoder42 closed this Jun 6, 2018
@nickluger nickluger mentioned this pull request Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants