Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use metro transformer in react native example #2000

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

vonovak
Copy link
Collaborator

@vonovak vonovak commented Aug 12, 2024

Description

follow up to #1999 which adds the feature to the RN example

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 6:59pm

Copy link

github-actions bot commented Aug 12, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.88 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.68 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@vonovak vonovak force-pushed the @vonovak/metro-transformer-example branch from 1dca203 to 815b90e Compare October 12, 2024 09:50
@vonovak vonovak force-pushed the @vonovak/metro-transformer-example branch from 815b90e to a29a470 Compare October 12, 2024 09:52
@@ -1,6 +1,6 @@
import "@formatjs/intl-locale/polyfill";
import "@formatjs/intl-locale/polyfill-force";
Copy link
Collaborator Author

@vonovak vonovak Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vonovak vonovak force-pushed the @vonovak/metro-transformer-example branch from 1c3e15e to af18537 Compare October 12, 2024 09:56
@vonovak vonovak changed the title @vonovak/metro transformer example chore: use metro transformer in react native example Oct 12, 2024
@vonovak vonovak marked this pull request as ready for review October 12, 2024 10:06
Comment on lines 30 to 31
"@lingui/cli": "^4.11.3",
"@lingui/macro": "^4.11.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be bumped to 4.12 as well, isn't it?

Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vonovak thank you!

@andrii-bodnar andrii-bodnar merged commit 75414db into main Oct 15, 2024
19 checks passed
@andrii-bodnar andrii-bodnar deleted the @vonovak/metro-transformer-example branch October 15, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants