-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add catalogsMergePath
in Lingui Configuration
#1881
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
catalogsMergePath
in **Lingui Configuration**catalogsMergePath
in *Lingui Configuration*
catalogsMergePath
in *Lingui Configuration*catalogsMergePath
in Lingui Configuration
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1881 +/- ##
==========================================
- Coverage 76.66% 76.63% -0.03%
==========================================
Files 81 81
Lines 2083 2089 +6
Branches 532 534 +2
==========================================
+ Hits 1597 1601 +4
Misses 375 375
- Partials 111 113 +2 ☔ View full report in Codecov by Sentry. |
BTW it still not clear from the docs what actually it does. Maybe add some examples with files tree before and after? |
Thanks for the suggestion 🤗. |
@aseerkt Thanks! I would suggest making the example more compact: use the code |
Also, we can reference our input data by the |
Thanks for the suggestion. |
maybe weird question, but, anyone tested this "Separate catalogs per component, placed inside component dir"? i don't remember this working from the code perspective.. |
It seems working @thekip . https://stackblitz.com/edit/vitejs-vite-rkaqac?file=lingui.config.ts |
We need to fix the {
"catalogs": [
{
"path": "/locale/{locale}/{name}",
- "include": "components/{name}/"
+ "include": ["components/{name}/"]
}
],
} Should I account for these changes in this PR? |
@aseerkt could you please fix this within the current PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aseerkt thank you!
Description
Include
catalogsMergePath
in Lingui Configuration reference section in docsTypes of changes
Fixes #1879
Checklist