-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RSpack + Lingui Example #1752
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Collinbrown95 thanks a lot for the contribution!
Could you please also add a link to the project on the Examples page in the docs?
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1752 +/- ##
=======================================
Coverage 75.98% 75.98%
=======================================
Files 81 81
Lines 2065 2065
Branches 530 530
=======================================
Hits 1569 1569
Misses 383 383
Partials 113 113 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Andrii Bodnar <andrii.bodnar@crowdin.com>
@andrii-bodnar thanks for the feedback! I've added the rspack example in this commit Collinbrown95@2958b03. Please let me know if you'd like any additional changes 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Collinbrown95 looks good to me, thank you! 🚀
@Collinbrown95 hey, I just tried to run this example in the repo and it doesn't work. There are bunch of issues:
/**
* @type {import('@rspack/cli').Configuration}
*/
module.exports = {
context: __dirname,
entry: {
main: "./src/main.tsx",
},
resolve: {
extensions: [".tsx", ".js", ".ts"],
},
builtins: {
html: [
{
template: "./index.html",
},
],
},
module: {
rules: [
{
test: /\.svg$/,
type: "asset",
},
{
test: /\.tsx?$/,
exclude: /node_modules/,
use: {
loader: "babel-loader",
options: {
presets: ["@babel/preset-typescript", "@babel/preset-react"],
plugins: ["macros"],
},
},
},
],
},
} But it still doesn't work. it starts without errors, but dev server returned an empty page. |
Description
Including example of integration between Rspack and Lingui-JS. Closes #1749.
Types of changes
Fixes # (issue)
Checklist