refactor(cli/catalog): decouple catalog type from Po message shape

[timofei-iatsenko]

Description

While working on a new xliff formatter realized that current shape of CatalogType and ExtractedMessage are tightly coupled to shape of the message of Pofile. There some properties which is related to po formatter only and should not be in the core type.

The same with other formatters. For example xliff may have additional attributes such as state=final which we also should store somewhere to not lost when extracting. So there should be a way to add some extra fields which would be preserved by cli and returned back to formatter.

In scheme it something like

formatter.parse -> extra: {special field} -> cli catalog processing -> formatter.serialize (get the same extra: {special field})

Notes:

i renamed extractedComments -> comments. this naming was because Pofile has it. When it's uncoupled, we don't
need it anymore and just comments looks much cleaner in the api.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

Fixes # (issue)

Checklist

• I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
js-lingui	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 22, 2023 at 11:17AM (UTC)

[github-actions]

size-limit report 📦

Path	Size
./packages/core/build/esm/index.js	1.61 KB (0%)
./packages/detect-locale/build/esm/index.js	812 B (0%)
./packages/react/build/esm/index.js	1.59 KB (0%)
./packages/remote-loader/build/esm/index.js	7.25 KB (0%)

[codecov]

Codecov Report

Patch coverage: 80.00% and no project coverage change.

Comparison is base (94a7e3c) 75.34% compared to head (3e2f749) 75.34%.

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #1549   +/-   ##
=======================================
  Coverage   75.34%   75.34%           
=======================================
  Files          78       78           
  Lines        1971     1971           
  Branches      516      516           
=======================================
  Hits         1485     1485           
  Misses        375      375           
  Partials      111      111           

Impacted Files	Coverage Δ
packages/format-po/src/po.ts	93.44% <77.77%> (ø)
packages/cli/src/api/catalog/extractFromFiles.ts	93.75% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[andrii-bodnar]

@thekip, just noticed - https://github.com/lingui/js-lingui/blob/next/website/docs/guides/custom-formatter.md?plain=1#L53 😬