-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): fix version command #1413
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Codecov ReportBase: 82.60% // Head: 69.62% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1413 +/- ##
===========================================
- Coverage 82.60% 69.62% -12.98%
===========================================
Files 56 72 +16
Lines 1799 2143 +344
Branches 506 581 +75
===========================================
+ Hits 1486 1492 +6
- Misses 183 516 +333
- Partials 130 135 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@thekip Please rebase to the new main which has this PR merged to it to fix the Codecov. |
That's something wrong in a different part. Codecov reporting that coverage dropped compared to some other base. What @andrii-bodnar did, it's just changing a threshold of what base could be. |
@thekip Ah, I see. But it is rather weird, in the PR #1408, this was the Codecov diff: But yours seem to have the |
Something wrong with codecov. My branch is on top of current main. Codecov generates report between my HEAD and ad9b735 wich is "fix: Local development not working on Windows" I have no idea why |
This issue looks similar https://community.codecov.com/t/incorrect-base-commit-of-pull-request/1779/2 |
It seems that it might the same issue as here: codecov/codecov-action#844? |
Anyway, it's not related to this PR. |
I have no idea why this is happening 😬 |
Description
Fixes: #1409
Let typescript do a "testing" and path rewriting.
Types of changes
Fixes # (issue)
Checklist